Fix file caching Issue with long URI's

cloudfoundry / ibm-websphere-liberty-buildpack

IBM WebSphere Application Server Liberty Buildpack

Apache License 2.0

72 stars 190 forks source link

Fix file caching Issue with long URI's #499

Closed rbamberger closed 3 years ago

rbamberger commented 3 years ago

This fixes the problem with long URI's used for downloading external dependencies causing filenames being generated that exceeds File System Limits. '.bin' Files need some special treatment because the code for using the ibmjdk has some built-in checks that rely on the original Filename to be able to expand the JRE. https://github.com/cloudfoundry/ibm-websphere-liberty-buildpack/blob/faf82f716e9ba6e3ed128ceabee131747cd9299b/lib/liberty_buildpack/jre/ibmjdk.rb#L131

linux-foundation-easycla[bot] commented 3 years ago

The committers are authorized under a signed CLA.

:white_check_mark: rbamberger (a11e43b2ff39c991e893ee2fe60eb57c4dea845f, 37c64b9d6f2fa4c4174d0020f1acfcfa0a352561, 6f69de7aadb0deee2bb1fc92c41ca918946033b8, cfd8534d25cef7e639de28787fd7c67ad022c005, e7db3d3d5a4f66f208358465ff040cc689f90a49, 7ef597cfd80af75d6b1aeeccd8ff1bbcc4b5e1e3)

kevin-ortega commented 3 years ago

@rbamberger Hi, i had to revert your PR because of some failing tests. You are welcome to resubmit a new PR but please run the unit test: https://github.com/cloudfoundry/ibm-websphere-liberty-buildpack#running-tests. Ensure there are no failures by either adjusting the code changes or when appropriate making changes in the test code.

elCucho04 commented 3 years ago

@rbamberger and @kevin-ortega how can we get this fix? it is impacting our teams ability to monitor their java apps.