search

cloudfoundry / ibm-websphere-liberty-buildpack

IBM WebSphere Application Server Liberty Buildpack
Apache License 2.0
72 stars 190 forks source link

Due to stability issues, changed back to use AgentNoRedefNoRetrans.jar. #521

Closed jy2697 closed 3 years ago

jy2697 commented 3 years ago

Due to stability issues, changed back to use AgentNoRedefNoRetrans.jar.

kevin-ortega commented 3 years ago

@jy2697 I merged this PR but I had to revert it because of spec errors this change caused. If you choose to resubmit these changes, please add evidence that you ran the spec tests in your PR. 

 [exec] Failures:
 [exec] 
 [exec]   1) CA APM Agent  release should return java command line options for the introscope service
 [exec]      Failure/Error: expect(java_opts).to include("-javaagent:./#{ca_apm_home}/wily/Agent.jar")
 [exec]        expected ["-javaagent:./.ca_apm/wily/AgentNoRedefNoRetrans.jar", "-Dorg.osgi.framework.bootdelegation=com.wily...engard.postofficehub.link.net.DefaultSocketFactory", "-Dcom.wily.introscope.agent.startup.mode=neo"] to include "-javaagent:./.ca_apm/wily/Agent.jar"
 [exec]      # ./spec/liberty_buildpack/framework/ca_apm_agent_spec.rb:159:in `block (3 levels) in <module:Framework>'
 [exec] 
 [exec]   2) CA APM Agent  release should return java command line options for the introscope service and have the agent manager credential if present
 [exec]      Failure/Error: expect(java_opts).to include("-javaagent:./#{ca_apm_home}/wily/Agent.jar")
 [exec]        expected ["-javaagent:./.ca_apm/wily/AgentNoRedefNoRetrans.jar", "-Dorg.osgi.framework.bootdelegation=com.wily...Factory", "-DagentManager.credential=test1234abcdf", "-Dcom.wily.introscope.agent.startup.mode=neo"] to include "-javaagent:./.ca_apm/wily/Agent.jar"
 [exec]      # ./spec/liberty_buildpack/framework/ca_apm_agent_spec.rb:178:in `block (3 levels) in <module:Framework>'
 [exec] 
 [exec] Finished in 4 minutes 20.9 seconds (files took 0.53474 seconds to load)
 [exec] 798 examples, 2 failures
 [exec] 
 [exec] Failed examples:
 [exec] 
 [exec] rspec ./spec/liberty_buildpack/framework/ca_apm_agent_spec.rb:151 # CA APM Agent  release should return java command line options for the introscope service
 [exec] rspec ./spec/liberty_buildpack/framework/ca_apm_agent_spec.rb:170 # CA APM Agent  release should return java command line options for the introscope service and have the agent manager credential if present