search

cloudfoundry / java-buildpack-auto-reconfiguration

Auto-reconfiguration functionality for the Java Buildpack
Apache License 2.0
219 stars 103 forks source link

Updated the regexps to pick up on play-slick database configurations #56

Closed dkowis closed 8 years ago

dkowis commented 8 years ago

This makes the java-buildpack-auto-reconfiguration work with the newer play-slick stuff. At least, with this, I'll be able to access the system properties again, and I can actually publish my play application to CloudFoundry.

I had to tweak the existing database configuration search to be more precise: It explicitly looks for . now.

Then I added another regexp to use when searching for slick configuration.

Play should barf if trying to use both configurations, so I didn't add any logic to make sure that they were mutually exclusive.

cfdreddbot commented 8 years ago

Hey dkowis!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

dkowis commented 8 years ago

This will resolve #55

chipchilders commented 8 years ago

CLA received