cloudfoundry / java-buildpack

Cloud Foundry buildpack for running Java applications
Apache License 2.0
435 stars 2.58k forks source link

Don't use lsb_release to find platform #1004

Closed ryanmoran closed 1 year ago

anthonydahanne commented 1 year ago

hello @ryanmoran - doesn't your change mean that if the underlying platform is neither redhat based nor ubuntu based, the platform will not be determined? ie: alpine, debian, etc. won't be recognized as valid platforms anymore.

Actually, is that an issue? I'm asking cause I got bit by this change while running the tests in a container based on debian

ryanmoran commented 1 year ago

Yes. I think the open question here is whether or not the buildpack needs to support these other OSes given that we basically only ship Ubuntu through the cflinuxfs* stacks.

anthonydahanne commented 1 year ago

yeah, fair enough, That makes sense, thanks.