cloudfoundry / java-buildpack

Cloud Foundry buildpack for running Java applications
Apache License 2.0
435 stars 2.58k forks source link

Add OpenTelemetry Javaagent framework #1020

Closed tylerbenson closed 8 months ago

tylerbenson commented 1 year ago

This framework will wire up the OpenTelemetry Javaagent auto instrumentation. It leverages VCAP_SERVICES and the existence of a service binding with a specific name (otel-collector).

Borrows from @breedx-splk's work in #968.

Prerequisite: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/8800

~Also, the otel-collector buildpack is not yet available, but perhaps the splunk collector could be utilized until it is.~ I'm told that VMware is planning to include the collector in the base images, so perhaps this won't be required.

tylerbenson commented 1 year ago

We now have a updated repository: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/cloudfoundry/index.yml

tylerbenson commented 11 months ago

@pivotal-david-osullivan could I get some eyes on this? Thanks!

tylerbenson commented 10 months ago

@pivotal-david-osullivan Thanks for catching all those. I've applied all the changes.

tylerbenson commented 10 months ago

@pivotal-david-osullivan following up here. Can we get this merged soon?

nrekretep commented 8 months ago

Hi there! @pivotal-david-osullivan Is there any progress in getting this feature merged? It would really very helpful to have this in the buildpack.