Migrate dynatrace integration to LD_PRELOAD and support FIPS mode

cloudfoundry / java-buildpack

Cloud Foundry buildpack for running Java applications

Apache License 2.0

433 stars 2.59k forks source link

Migrate dynatrace integration to LD_PRELOAD and support FIPS mode #1041

Closed joushx closed 6 months ago

joushx commented 8 months ago

Migrate the dnytrace integration to use the LD_PRELOAD method as used within other buildpacks and support FIPS mode.

Set LD_PRELOAD environment variable instead of java options
Add option to enable FIPS cryptographic mode
adapt tests and test fixtures

linux-foundation-easycla[bot] commented 8 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: joushx / name: Johannes Mittendorfer (93226a348fcbc2ae7589ab205f74b86f7e6c24d1, a2f6d9637bb593febaf8c253ca61738a4619dea8, a42f608d69b7c5c7f8179a8bd6369624f996b15c, 48d0e026934326d205be5d3cf039bed202383881, 0490c5d82edd2faa33a8a5eb10cc1c73e0662091, 4b1f6ca709b23a3905fe5b916644c7329a630a42)

meibensteiner commented 7 months ago

@dmikusa @pivotal-david-osullivan Could you please take a look? We have some customers who want to switch to the updated buildpack by end of year.

dmikusa commented 7 months ago

@meibensteiner Hi, sorry for the delay. The PR looks OK but it has to go through some manual testing. Testing with the CF JBP is time-consuming, but helps ensure we don't have any regressions. Once that's done we'll move forward and get it merged. Thanks in advance for your patience.

TimGerlach commented 7 months ago

Hi @dmikusa , Have you had a chance to perform the manual testing that you mentioned previously? I'm asking because we are running a critical project that requires this PR to be merged before the end of this year. We appreciate your support.

pivotal-david-osullivan commented 7 months ago

@TimGerlach @anthonydahanne is working on this testing, we are aiming to get this out in a release next week!

anthonydahanne commented 7 months ago

@dmikusa , @pivotal-david-osullivan I could test this change, using:

  buildpacks:
    -  https://github.com/joushx/java-buildpack

and using my own Dynatrace trial account - everything still worked fine,see screenshots Screenshot 2023-12-19 at 14 33 20 Screenshot 2023-12-19 at 14 31 02

You'll need to rebase this branch though before merging; it's pretty far behind now.

Thanks @joushx for your patience!

joushx commented 7 months ago

Nice, thank you! I just did the rebase.

joushx commented 6 months ago

Linter suggestions applied