search

cloudfoundry / java-buildpack

Cloud Foundry buildpack for running Java applications
Apache License 2.0
439 stars 2.58k forks source link

Provide possibility to sent http headers in download request #685

Closed DTMad closed 4 years ago

DTMad commented 5 years ago

We would like to provide http headers when using the download function (e.g. change User-Agent, provide additional headers, ...) to get more detailed information.

Please provide an option to make this possible.

mreider commented 5 years ago

@nebhale - sorry to harass you - we're wondering if you could find the time to look at this. Our sec / ops team had some concerns here since using http headers won't leave tokens in log files. We tried to understand how to modify the code ourselves, but need a hand.

nebhale commented 4 years ago

As we're closing in on the migration to Cloud Native Buildpacks, we're not going to make any change this invasive to the main buildpack. The code that all downloads route through is located here, but beware that any modification to this area of code is unsupported and bugs against buildpacks with modifications against non-public API (that's what this is) will not be investigated.