search

cloudfoundry / java-buildpack

Cloud Foundry buildpack for running Java applications
Apache License 2.0
437 stars 2.58k forks source link

Support for Splunk OpenTelemetry Java Instrumentation #825

Open mateuszrzeszutek opened 4 years ago

mateuszrzeszutek commented 4 years ago

Hi,

I want to add a new framework that adds Splunk OTel instrumentation agent support. The agent collects telemetry sends it usually to either OpenTelemetry collector or the SignalFX Smart Agent.

The new framework will only be added when it's explicitly enabled (similar to how it's done in e.g. YourKit profiler). It'll download a jar with the Java agent and pass its path to the JVM through -javaagent together with some system properties (in case the user wants to change the default configuration of the agent).

Please let me know if it's OK to add this here -- I assumed that this repo would be a good place because there already are some Java agents here (AppD, NewRelic etc).

nebhale commented 3 years ago

Hey there @mateuszrzeszutek. We would be happy to accept such a contribution, although unlike YourKit it should be enabled via a service binding which contains connection information such as the destination to stream data to. Most of the other agents behave like this, but YourKit and a small number of others are manually enabled because they accept inbound connections (no obvious connection information) instead of making outbound connections.

metacubed commented 3 years ago

@mateuszrzeszutek are there any updates on this support?

mateuszrzeszutek commented 3 years ago

Hey @metacubed, For simplicity (and faster development) we've ended up building our separate buildpack just for the agent, you can find it here. Unfortunately we don't have time & resources right now to work on adding our agent to the java-buildpack.

breedx-splk commented 2 years ago

Just an update -- we are come back around on this and hope to contribute a service binding in the near future. Thanks for your patience.

breedx-splk commented 2 years ago

Just wanted to gently nudge this in hopes of getting some eyes on #968. Thanks.