search

cloudfoundry / java-buildpack

Cloud Foundry buildpack for running Java applications
Apache License 2.0
437 stars 2.58k forks source link

Introduce the splunk-otel-java-agent framework. #968

Closed breedx-splk closed 1 year ago

breedx-splk commented 1 year ago

This framework will wire up the Splunk distribution of OpenTelemetry java for auto-instrumentation and direct ingest. It leverages VCAP_SERVICES and the existence of a service binding with a specific name (splunk-o11y).

Signed-off-by: Jason Plumb jplumb@splunk.com

Resolves issue #825

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

breedx-splk commented 1 year ago

Thanks @dmikusa for the review...greatly appreciated. I made some changes and am ready for another look.

breedx-splk commented 1 year ago

Hi @dmikusa Just checking back in after a few days. Thanks.

dmikusa commented 1 year ago

Apologizes. I don't have access to CF environments at the moment. @pivotal-david-osullivan would need to provide final review & merge.

breedx-splk commented 1 year ago

Hi @pivotal-david-osullivan any chance to get a review on this please? 🙏🏻

pivotal-david-osullivan commented 1 year ago

Apologies for the delay, I had some issues getting environments too, I will review and update ASAP!

breedx-splk commented 1 year ago

@pivotal-david-osullivan Just touching base again. 🤞🏻 Thanks.

breedx-splk commented 1 year ago

Nudging this again to keep this alive.....thanks in advance.

breedx-splk commented 1 year ago

Maybe we could get a look before the year is over?

pivotal-david-osullivan commented 1 year ago

I was able to get a lab and test this, the agent downloads and I see some initial output. Thank you for your patience on this @breedx-splk and thanks again for the PR, I've merged it in!