Fix wrong call of void method dumpHeap()

cloudfoundry / jvmkill

Terminate the JVM when resources are exhausted

Apache License 2.0

30 stars 11 forks source link

Fix wrong call of void method dumpHeap() #34

Closed schmelter-sap closed 2 years ago

schmelter-sap commented 2 years ago

This is a fix for https://github.com/cloudfoundry/jvmkill/issues/18

It replaces the call to HotSpotDiagnosticMXBBean.dumpHeap(...) via CallObjectMethodA with CallVoidMethodA, since the dumpHeap() method is indeed a void method and the check for the return value formerly done can lead to spurious error messages.

linux-foundation-easycla[bot] commented 2 years ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: schmelter-sap / name: Ralf Schmelter (3be1df0933e1387fd4107022765292091c2cec39)

dmikusa commented 2 years ago

I took a quick look through and it looks good to me. Are you working on the EasyCLA bot? We'll need to get that green before I can merge. There are instructions in the link above. Thanks

schmelter-sap commented 2 years ago

I've triggered the EasyCLA proess, but it is holiday season.

dmikusa commented 2 years ago

Sure, no hurry. If you could ping back when it gets processed, I can merge this. Unfortunately, it does not update the issue when EasyCLA passes so I don't get a notification when that happens.

schmelter-sap commented 2 years ago

@dmikusa CLA is now processed.