[Feature]: Specifying an unsupported stack errors

[matt-royal]

Blockers/Dependencies

1054

Background

As a cf CLI user I want to receive an error message when I select a stack other than io.buildpacks.stacks.bionic (or whatever the current supported stack is) So that I understand that I cannot build images based on that stack (right now we silently ignore the requested stack)

Acceptance Criteria

GIVEN a korifi cluster WHEN I run cf push -s no-such-stack THEN I should see that the build fails with an error explaining that no stack with that name exists

---

WHEN I run cf push -s io.buildpacks.stacks.bionic or cf push THEN I should see that the build succeeds AND that cf app <AppName> shows stack io.buildpacks.stacks.bionic

Dev Notes

This story spans korifi/api, korifi/controllers, and korifi/kpack-image-builder.

• In korifi/api:

  • The API, payload and BuildRepository must respect the user-specified stack
  • When no stack is specified, the stack should be left blank on CFBuild

• In korifi/controllers:

  • The BuildWorkload CRD now has a spec.stack field, which can be blank
  • The CFBuildReconciler sets BuildWorkload.spec.stack based on the value in CFBuild.spec.lifecycle.data.stack

• In korifi/kpack-image-builder:

  • If the BuildWorkload.spec.stack doesn't match a supported stack (at the moment, only io.buildpacks.stacks.bionic is supported), then the Succeeded status condition becomes false with a message that explains that the requests stack doesn't exist.

When a stack is specified to cf push, the manifest will look like this:

applications:
- name: my-app
  # ...
  stack: stack

[matt-royal]

I'm writing this story for an interview this week. It hasn't been IPMed, and we may choose not to merge the result.