search

cloudfoundry / korifi

Cloud Foundry on Kubernetes
Apache License 2.0
317 stars 65 forks source link

[Bug]: FAIL: TestSuite/API_Shim/App_Repository_Secret_Create/Update/an_envSecret_is_created_for_a_CFApp_with_the_Repo/returns_a_record_matching_the_input_and_no_error #176

Closed danail-branekov closed 2 years ago

danail-branekov commented 3 years ago

What happened?

There is a consistently failing unit tests, see the output below (the commit sha is available at the end of the output):

❯ make test
go fmt ./...
go: downloading k8s.io/client-go v0.22.1
go: downloading k8s.io/api v0.22.1
go: downloading k8s.io/apimachinery v0.22.1
go vet ./...
mkdir -p /home/danailster/workspace/cf-k8s-api/testbin
test -f /home/danailster/workspace/cf-k8s-api/testbin/setup-envtest.sh || curl -sSLo /home/danailster/workspace/cf-k8s-api/testbin/setup-envtest.sh https://raw.githubusercontent.com/kubernetes-sigs/controller-runtime/v0.8.3/hack/setup-envtest.sh
source /home/danailster/workspace/cf-k8s-api/testbin/setup-envtest.sh; fetch_envtest_tools /home/danailster/workspace/cf-k8s-api/testbin; setup_envtest_env /home/danailster/workspace/cf-k8s-api/testbin; go test ./... -coverprofile cover.out -shuffle on
Using cached envtest tools from /home/danailster/workspace/cf-k8s-api/testbin
setting up env vars
?       code.cloudfoundry.org/cf-k8s-api        [no test files]
ok      code.cloudfoundry.org/cf-k8s-api/apis   0.078s  coverage: 87.0% of statements
?       code.cloudfoundry.org/cf-k8s-api/apis/fake      [no test files]
?       code.cloudfoundry.org/cf-k8s-api/config [no test files]
?       code.cloudfoundry.org/cf-k8s-api/payloads       [no test files]
?       code.cloudfoundry.org/cf-k8s-api/presenter      [no test files]
-test.shuffle 1632908719503214819
2021-09-29T09:45:19.503Z        DEBUG   controller-runtime.test-env     starting control plane
2021-09-29T09:45:26.588Z        DEBUG   controller-runtime.test-env     installing CRDs
2021-09-29T09:45:26.589Z        DEBUG   controller-runtime.test-env     reading CRDs from path  {"path": "fixtures/vendor/cf-k8s-controllers/config/crd/bases"}
2021-09-29T09:45:26.589Z        DEBUG   controller-runtime.test-env     read CRDs from file     {"file": "networking.cloudfoundry.org_cfdomains.yaml"}
2021-09-29T09:45:26.590Z        DEBUG   controller-runtime.test-env     read CRDs from file     {"file": "networking.cloudfoundry.org_cfroutes.yaml"}
2021-09-29T09:45:26.590Z        DEBUG   controller-runtime.test-env     read CRDs from file     {"file": "workloads.cloudfoundry.org_cfapps.yaml"}
2021-09-29T09:45:26.592Z        DEBUG   controller-runtime.test-env     read CRDs from file     {"file": "workloads.cloudfoundry.org_cfbuilds.yaml"}
2021-09-29T09:45:26.593Z        DEBUG   controller-runtime.test-env     read CRDs from file     {"file": "workloads.cloudfoundry.org_cfpackages.yaml"}
2021-09-29T09:45:26.594Z        DEBUG   controller-runtime.test-env     read CRDs from file     {"file": "workloads.cloudfoundry.org_cfprocesses.yaml"}
2021-09-29T09:45:26.617Z        DEBUG   controller-runtime.test-env     installing CRD  {"crd": "cfroutes.networking.cloudfoundry.org"}
2021-09-29T09:45:26.627Z        DEBUG   controller-runtime.test-env     installing CRD  {"crd": "cfapps.workloads.cloudfoundry.org"}
2021-09-29T09:45:26.659Z        DEBUG   controller-runtime.test-env     installing CRD  {"crd": "cfbuilds.workloads.cloudfoundry.org"}
2021-09-29T09:45:26.674Z        DEBUG   controller-runtime.test-env     installing CRD  {"crd": "cfpackages.workloads.cloudfoundry.org"}
2021-09-29T09:45:26.682Z        DEBUG   controller-runtime.test-env     installing CRD  {"crd": "cfprocesses.workloads.cloudfoundry.org"}
2021-09-29T09:45:26.691Z        DEBUG   controller-runtime.test-env     installing CRD  {"crd": "cfdomains.networking.cloudfoundry.org"}
2021-09-29T09:45:26.697Z        DEBUG   controller-runtime.test-env     adding API in waitlist  {"GV": "networking.cloudfoundry.org/v1alpha1"}
2021-09-29T09:45:26.697Z        DEBUG   controller-runtime.test-env     adding API in waitlist  {"GV": "workloads.cloudfoundry.org/v1alpha1"}
2021-09-29T09:45:26.697Z        DEBUG   controller-runtime.test-env     adding API in waitlist  {"GV": "workloads.cloudfoundry.org/v1alpha1"}
2021-09-29T09:45:26.697Z        DEBUG   controller-runtime.test-env     adding API in waitlist  {"GV": "workloads.cloudfoundry.org/v1alpha1"}
2021-09-29T09:45:26.698Z        DEBUG   controller-runtime.test-env     adding API in waitlist  {"GV": "workloads.cloudfoundry.org/v1alpha1"}
2021-09-29T09:45:26.698Z        DEBUG   controller-runtime.test-env     adding API in waitlist  {"GV": "networking.cloudfoundry.org/v1alpha1"}
2021-09-29T09:45:26.802Z        DEBUG   controller-runtime.test-env     installing webhooks
--- FAIL: TestSuite (9.54s)
    --- FAIL: TestSuite/API_Shim (0.69s)
        --- FAIL: TestSuite/API_Shim/App_Repository_Secret_Create/Update/an_envSecret_is_created_for_a_CFApp_with_the_Repo/returns_a_record_matching_the_input_and_no_error (0.01s)
            app_repository_test.go:547:
                Expected
                    <string>: f9c714d2-2109-11ec-ac9b-42010a9a000
                to equal
                    <string>: f9c714d2-2109-11ec-ac9b-42010a9a000e
FAIL
coverage: 83.7% of statements
FAIL    code.cloudfoundry.org/cf-k8s-api/repositories   9.571s
FAIL
make: *** [Makefile:29: test] Error 1

~/workspace/cf-k8s-api main 40s
2 ❯❯ git show --oneline
69945ad (HEAD -> main, origin/main, origin/HEAD) Merge pull request cloudfoundry/cf-k8s-api#92 from cloudfoundry/wip-handler-contructors

What you expected to happen

make test should complete successfully with all tests passing

Acceptance Criteria

GIVEN the api repo is checked out WHEN I run make test THEN I see no errors

How to reproduce it (as minimally and precisely as possible)

just run make test

Anything else we need to know?

No response

Environment

Revision of codebase: 69945ad Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2", GitCommit:"092fbfbf53427de67cac1e9fa54aaa09a28371d7", GitTreeState:"clean", BuildDate:"2021-06-16T12:59:11Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}

Cloud provider or hardware configuration: GCP Linux VM

❯ uname -a
Linux danailster-eirini-station 5.8.0-1035-gcp cloudfoundry/cf-k8s-api#37~20.04.1-Ubuntu SMP Thu Jun 17 16:04:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Others:

tcdowney commented 2 years ago

@danail-branekov is this still an issue or can we close it?

danail-branekov commented 2 years ago

This is such an old issue... Nowadays tests are green so I suppose it has been sorted out.