cloudfoundry / korifi

Cloud Foundry on Kubernetes
Apache License 2.0
318 stars 65 forks source link

Make managed binding finalizer a no-op #3604

Closed zabanov-lab closed 2 weeks ago

zabanov-lab commented 2 weeks ago

The reason we do this is because the previous implenetation was flawed. Finalization logic was depending on the cfservice instance being there, which was often not the case. When the cfserviceinstance was gone the cfservicebinding was implssible to finalize, causing the whole org to become un-deleteable. This introduced a major blocker for CI. We have to reconsider the way we do finalization of managed bindings and come back with a better implenetation.

Is there a related GitHub Issue?

No

What is this change about?

Make managed binding finalizer a no-op

Does this PR introduce a breaking change?

No