[Chore]: Refactor api/repositories errors

[Birdrock]

Background

There are 3 separate errors types for resources not found or permissions issues. NotFoundError can contain the most information. ResourceNotFoundError is unused. PermissionDeniedOrNotFoundError is used in a few places.

Action to take

• Choose an error name.
• Consolidate error types and refactor references. Include ResourceType information where appropriate.

Impact

This will reduce some clutter in logging and eliminate dead code. This is low impact tech debt.

Dev Notes

https://github.com/cloudfoundry/cf-k8s-controllers/blob/issue-398/api/repositories/errors.go

Is denied or not found a convention?

[kieron-dev]

ToDo:

• [x] Write ADR
• [x] AppRepo::GetApp
  • [x] AppRepo::GetAppEnv
  • [x] FetchProcessStats::Invoke
• [x] AppRepo::GetNamespace
• [x] AppRepo::SetAppDesiredState
• [x] DomainRepo::GetDomain
• [x] OrgRepo::GetOrg
  • [x] OrgRepo::CreateSpace
• [x] Cleanup Repo errors

[julian-hj]

@kieron-dev @gcapizzi @Birdrock we see that this is marked as "done" in the project. Can the issue be closed also, or is there some process subtlety that I'm not aware of?

[kieron-dev]

@julian-hj Yep - this should be closed. We don't require any PM style acceptance on chores.