search

cloudfoundry / korifi

Cloud Foundry on Kubernetes
Apache License 2.0
317 stars 65 forks source link

Eirini's LRP environment variables should be stored in a secret #924

Closed danail-branekov closed 2 years ago

danail-branekov commented 2 years ago

Eirini LRPs have their environment variables as a plain-text key-value map. This is a bit insecure as anyone having permissions on getting LRPs would be able to see the underlying app environment, which may contain sensitive data.

Therefore, in order to fix this we should change the LRPs Env type to corev1.EnvVar which is the standard k8s way of securely injecting environment into app containers.

danail-branekov commented 2 years ago

Duplicate of https://github.com/cloudfoundry/cf-k8s-controllers/issues/917, closing