cloudfoundry / loggregator-agent-release

Apache License 2.0

14 stars 28 forks source link

Add support to send LOG and EVENT to OtelCollector as logs #603

Closed mkocher closed 1 month ago

mkocher commented 1 month ago

Description

This incorporates the changes from #595 to add support for forwarding logs over otlp. It also adds configuration to turn logs/metrics/traces on and off.

⚠️ This change renames temporary_emit_otel_traces ⚠️ We don't believe anyone is using it, and since we were adding the other signals we figure these properties are as permanent as any others.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing performed?

[x] Unit tests
[ ] Integration tests
[ ] Acceptance tests

Checklist:

[x] This PR is being made against the main branch, or relevant version branch
[ ] I have made corresponding changes to the documentation
[x] I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

mkocher commented 1 month ago

In https://github.com/cloudfoundry/otel-collector-release/pull/48 we made the otel-collector release add noop pipelines for any signal that doesn't have a pipeline defined. This should make it safe to turn these properties on by default, and allow users to turn them off as a (probably minor) performance optimization if they want to.