cloudfoundry / loggregator-agent-release

Apache License 2.0
14 stars 28 forks source link

the retry_writer retries parsing issues for syslog messages #612

Open nicklas-dohrn opened 2 weeks ago

nicklas-dohrn commented 2 weeks ago

due to the error propagation from the Writer to the retry_writer, the call of msgs, err := w.syslogConverter.ToRFC5424(env, w.hostname) can trigger a retry on a parsing issue, resulting in logs suggesting there where some connection issues, when the issue was indeed a parsing failure. Retrying a parsing failure will also not resolve on retries, making the loop inefficient in this case.