cloudfoundry / loggregator-release

Cloud Native Logging

Apache License 2.0

215 stars 149 forks source link

Bump google.golang.org/grpc to v1.63.2 #743

Closed acrmp closed 5 months ago

acrmp commented 5 months ago

Description

Ignore lint warnings and continue to use grpc.Dial rather than grpc.NewClient
grpc.NewClient will ignore the WithBlock option that we rely on. We want to continue to use grpc.Dial on this branch for backwards compatibility.

Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing performed?

[X] Unit tests
[X] Integration tests
[ ] Acceptance tests

Checklist:

[X] This PR is being made against the main branch, or relevant version branch
[ ] I have made corresponding changes to the documentation
[ ] I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack