Do not always print service is optional during failure

cloudfoundry / multiapps-controller

The server side component (controller) for Multi-Target Application (MTA) for Cloud Foundry

Apache License 2.0

57 stars 42 forks source link

Do not always print service is optional during failure #1428

Closed Yavor16 closed 7 months ago

Yavor16 commented 7 months ago

LMCROSSITXSADEPLOY-2878

IvanBorislavovDimitrov commented 7 months ago

instead of having the condition in every step can you extract it in: ServiceStep::processServiceActionFailure only?

You can have 2 types of messages: Error creating or updating optional service instance (for optional) Error creating or updating service instance (for non-optional)

This way in the steps Update,CreateService, etc, you're just throwing the exception and its message will be added.

Thus you will not have the code duplication

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud