cloudfoundry / nginx-buildpack

Cloud Foundry buildpack that provides NGINX
Apache License 2.0
30 stars 66 forks source link

Incorrect version of NGINX Deprecated #137

Closed absoluteZero87 closed 2 years ago

absoluteZero87 commented 2 years ago

What version of the buildpack you are using? v1 .1.38

If you were attempting to accomplish a task, what was it you were attempting to do? Deploy NGINX

What did you expect to happen? NGINX Deployed

What was the actual behavior? Deploy NGINX Failed due to deprecation warnings


In the manifest.yml

dependency_deprecation_dates:
- version_line: 1.20.x
  name: nginx
  date: 2022-05-25
  link: https://nginx.org/
- version_line: 1.21.x
  name: nginx
  date: 2022-05-25
  link: https://nginx.org/

It appears that version 1.21.X has been deprecated however I believe 1.21.6 is the latest version of NGINX

absoluteZero87 commented 2 years ago

Log from current build process

07:56:10  [build] [Task 0/run-lifecycle] -----> Nginx Buildpack version 1.1.38
07:56:10  [build] [Task 0/run-lifecycle] -----> Supplying nginx
07:56:10  [build] [Task 0/run-lifecycle] -----> No nginx version specified - using mainline => 1.21.6
07:56:10  [build] [Task 0/run-lifecycle] -----> Installing nginx 1.21.6
07:56:10  [build] [Task 0/run-lifecycle]        Download [https://buildpacks.cloudfoundry.org/dependencies/nginx/nginx_1.21.6_linux_x64_cflinuxfs3_72c2318f.tgz]
07:56:10  [build] [Task 0/run-lifecycle]        **WARNING** nginx 1.21.x will no longer be available in new buildpacks released after 2022-05-25.
07:56:10  [build] [Task 0/run-lifecycle]        See: https://nginx.org/
07:56:10  [build] [Task 0/run-lifecycle]        **ERROR** Could not validate nginx.conf: exit status 1
arjun024 commented 2 years ago

Yes. the deprecation date metadata is just an estimation based on nginx's release cadence as explained here (https://www.nginx.com/blog/nginx-1-18-1-19-released/)

I agree with you that this estimated date causes confusion to users. We'll get the warning removed. Thanks for reporting the issue

brayanhenao commented 2 years ago

Hi @absoluteZero87, the deprecation warning will be removed in the next Nginx release (expected at most by the end of next week)

leon0707 commented 2 years ago

is the error "ERROR Could not validate nginx.conf: exit status 1" caused by the warning?

brayanhenao commented 2 years ago

@leon0707 No, that issue is not related to this one. You can open a new issue in which you can give us more information about the problem to follow up on it.