cloudfoundry / nginx-buildpack

Cloud Foundry buildpack that provides NGINX
Apache License 2.0
30 stars 66 forks source link

Feature Request: --with-http_image_filter_module #25

Closed noriega3 closed 4 years ago

noriega3 commented 4 years ago

What version of Cloud Foundry and CF CLI are you using? (i.e. What is the output of running cf curl /v2/info && cf version? cli "6.23.0" cf version 6.45.0+5f9ff16f9.2019-06-03

What version of the buildpack you are using? nginx_buildpack-cached-cflinuxfs3-v1.1.1.zip

If you were attempting to accomplish a task, what was it you were attempting to do? utilize https://nginx.org/en/docs/http/ngx_http_image_filter_module.html#image_filter

What did you expect to happen? able to use module {{module "http_image_filter_module"}} at the top of nginx.conf

What was the actual behavior? not found

Please confirm where necessary:

10:45:32 Downloaded app package (210.4K)
10:45:32 -----> Nginx Buildpack version 1.1.1
10:45:32 -----> Supplying nginx
10:45:32 -----> Requested nginx version: mainline => 1.17.5
10:45:32 -----> Installing nginx 1.17.5
10:45:32        Copy [/tmp/buildpacks/xxxxxxxx/dependencies/xxxxxxx/nginx-1.17.5-linux-x64-cflinuxfs3-fa554ae5.tgz]
10:45:32 2020/02/11 15:45:32 [emerg] 39#0: dlopen() "/tmp/xxxxxx/modules/ngx_http_image_filter_module.so" failed (/tmp/xxxxxx/modules/ngx_http_image_filter_module.so: cannot open shared object file: No such file or directory) in /tmp/xxxxxx/nginx.conf:1
10:45:32 nginx: configuration file /tmp/xxxxxx/nginx.conf test failed
10:45:32        **ERROR** Could not validate nginx.conf: nginx.conf contains syntax errors: exit status 1
10:45:32 Failed to compile droplet: Failed to run all supply scripts: exit status 14
10:45:32 Exit status 223
cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/171212045

The labels on this github issue will be updated when the story is started.

ryanmoran commented 4 years ago

@noriega3 The ngx_http_image_filter_module is not one of the statically or dynamically loaded modules included in the nginx-buildpack. You can see those listed in the documentation here: https://docs.cloudfoundry.org/buildpacks/nginx/index.html#loading-modules.

This means that you would need to include this module in your own modules directory in your source code for this to work for your application.

dwillist commented 4 years ago

@noriega3 We are closing this due to lack of activity. It seems that --with-http_image_filter_module is a nginx module that can be loaded by some user configuration.

If there are other reasons why this module cannot be loaded, or other concerns please re-open this.