cloudfoundry / nodejs-buildpack

Cloud Foundry buildpack for Node.js
http://docs.cloudfoundry.org/buildpacks/
Apache License 2.0
170 stars 384 forks source link

Bundle newrelic, similar to the java buildpack? #48

Closed TuckerWhitehouse closed 8 years ago

TuckerWhitehouse commented 8 years ago

Would be beneficial to have newrelic bundled similar to the java buildpack, with configuration driven through environment variables.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/114424769.

Dannyzen commented 8 years ago

Hey @TuckerWhitehouse we like the idea of giving users the ability to deploy an app and have it "automagically" connect to the newrelic service, however aren't keen on the idea that the binary exists in the buildpack. Here's an outline of some challenges:

Licensing

In order to support a 3rd party vendor with a redistribution license that is incompatible with Cloud Foundry’s needs: A legal process would need to take place to remedy the licensing incompatibility. In the case where a vendor refuses to modify their licensing:

Security

Forking

We're currently researching a solution that would still enable the user the magic the java buildpack provides, but without having the binary in the buildpack.

TuckerWhitehouse commented 8 years ago

I'm sorry, but haven't these issues already been resolved in respect to the java buildpack, or is the licensing and security somehow different when it applies to node?

Dannyzen commented 8 years ago

Hey @TuckerWhitehouse we've discussed this issue and are considering this request

aloismayr commented 8 years ago

Any news to share on this?

Dannyzen commented 8 years ago

@aloismayr thanks for reaching out, no news as of yet.

Dannyzen commented 8 years ago

We would be open to receiving a pull request from the team at New Relic or from the community. At this point we do not have any plans on performing this line of work ourselves.