search

cloudfoundry / notifications

The notifications service component of Cloud Foundry
Apache License 2.0
17 stars 22 forks source link

Unit tests require a MySQL server #20

Closed osis closed 5 years ago

osis commented 5 years ago

I'm not sure if this is intended, but it does seem like there is something going awry.

When running the unit tests, you'll see the skip status message of...

Will skip:
  ./db
  ./gobble
  ./v1/acceptance
  ./v1/models

but you'll eventually get this error...

[BeforeSuite] BeforeSuite
/Users/user/go/src/github.com/cloudfoundry-incubator/notifications/gobble/init_test.go:25

  Test Panicked
  dial tcp 127.0.0.1:3306: connect: connection refused

Seems like it's running something that it says it should be? 🤔

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

osis commented 5 years ago

Totally overlooked this line of code.

https://github.com/cloudfoundry-incubator/notifications/blob/35d0fbf810cf362089a358be480257294c152dc1/bin/unit#L34

Seems like there should be a third suite of integration tests that can run on their own.