Manifest specifies Go buildpack

cloudfoundry / notifications

The notifications service component of Cloud Foundry

Apache License 2.0

17 stars 22 forks source link

Manifest specifies Go buildpack #7

Closed rosenhouse closed 7 years ago

rosenhouse commented 7 years ago

this speeds up deployment, since the stager only needs to download the 1 buildpack, not all of them
are there environments where the go buildpack has a non-standard name? in that case, this could cause a problem.

@ryanmoran I can't recall if there was a reason we didn't set this before....

cfdreddbot commented 7 years ago

Hey rosenhouse!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

evanfarrar commented 7 years ago

We didn't specify it at the time because buildpacks didn't support any form of floating semver, i.e. if you specified 1.5 it would not use 1.5.1 and so on, so it was either major float or be forever locked.