search

cloudfoundry / otel-collector-release

BOSH release for the OpenTelemetry Collector
Apache License 2.0
0 stars 1 forks source link

Enable global port listening #12

Closed jbooherl closed 4 months ago

jbooherl commented 4 months ago

Add a property that enables the ability for external VMs to write to the Otel ingress porr

acrmp commented 4 months ago

Thanks @jbooherl!

Rather than using the boolean property, what if we instead just accepted an ingress.grpc.listen_address property so that we don't have to switch in the template?

We also have some template tests. Could you add an example for this case there? https://github.com/cloudfoundry/otel-collector-release/blob/main/spec/support/shared_examples_for_otel_collector.rb

jbooherl commented 4 months ago

Sounds good, also question.. I'm not really a rubyer, when I run bundle exec rspec I get a lot of unknown keyword: :aliases Is there an easy was to fix this so I can run these tests in the future?

ctlong commented 4 months ago

@jbooherl it looks like @mkocher has incorporated the requested change into his PR:

In that case, I think we can close out this PR, if that's alright with you?

jbooherl commented 4 months ago

Sounds good to me!