cloudfoundry / php-buildpack

A Cloud Foundry Buildpack for PHP.
Apache License 2.0
142 stars 347 forks source link

Use https instead of git+ssh for podhmo/python-node-semver submodule #1098

Closed gmllt closed 1 week ago

gmllt commented 1 month ago

Short explanation of the proposed change: Use https instead of git+ssh for podhmo/python-node-semver git submodule as it can cause problems in certain environments where only retrieval of a git repository via https is allowed.

Explanation of the use cases your change solves: Fix git submodul retrieval in environments where git clone is only allowed through https.

amhuber commented 1 month ago

This is breaking our automated buildpack packing job as well, please merge this so we can use the new buildpack.

gmllt commented 1 month ago

@amhuber as a workaround, you can force git to use https://github.com/ instead of git@github.com: in git config:

[url "https://github.com/"]
    insteadOf = git@github.com:
arthfl commented 2 weeks ago

Any news on this? It breaks a couple of our deployments and we currently have to pin them to use 4.6.23.

mohdazaruddin commented 1 week ago

I see 4.6.25 is released but still uses ssh method for this submodule. Still breaks our deployments too..Any news on this to change to https?