cloudfoundry / php-buildpack

A Cloud Foundry Buildpack for PHP.
Apache License 2.0
142 stars 347 forks source link

Pushing apps with v4.6.24 fails with "Failed to clone git repository..." #1110

Open milen-a-radev opened 1 month ago

milen-a-radev commented 1 month ago

What version of Cloud Foundry and CF CLI are you using? (i.e. What is the output of running cf curl /v2/info && cf version?

cf curl /v2/info {"name":"cf-deployment","build":"v1.60.0","support":"support@...","version":42,"description":"","authorization_endpoint":"https://login.system...","token_endpoint":"https://uaa.system...","min_cli_version":null,"min_recommended_cli_version":null,"app_ssh_endpoint":"ssh.system...:2222","app_ssh_host_key_fingerprint":"...","app_ssh_oauth_client":"ssh-proxy","doppler_logging_endpoint":"wss://doppler.system...:443","api_version":"2.237.0","osbapi_version":"2.15","routing_endpoint":"https://api.system.../routing","user":"..."}

cf version cf version 8.8.2+483578c.2024-09-20

What version of the buildpack you are using? v4.6.24

If you were attempting to accomplish a task, what was it you were attempting to do? Push an application using v4.6.24

What did you expect to happen? Successfully deployed application

What was the actual behavior? The push failed with

   Failed to clone git repository at https://github.com/cloudfoundry/php-buildpack
   Exit status 1
   Cell ff0ee002-233b-47d5-8471-5a96104cfde1 stopping instance c050bcb6-5a3d-4c3f-8608-6505f1121e5a
   Cell ff0ee002-233b-47d5-8471-5a96104cfde1 destroying container for instance c050bcb6-5a3d-4c3f-8608-6505f1121e5a
StagingError - Staging error: staging failed
FAILED

Please confirm where necessary:

Steps for reproduction:

git clone https://github.com/cloudfoundry-samples/cf-ex-stand-alone.git
cd cf-ex-stand-alone
sed -i .bak 's@php_buildpack@https://github.com/cloudfoundry/php-buildpack#v4.6.24@g' manifest.yml
cf push
cf logs cf-ex-stand-alone --recent

Results: repro_recipe.txt

milen-a-radev commented 1 month ago

Our troubleshooting points to line 12 in .gitmodules:

url = git@github.com:podhmo/python-node-semver.git

Our environment only allows HTTPS egress, so using SSH fails for us.

PR 1098 should fix it.