cloudfoundry / postgres-release

BOSH release for PostgreSQL
Apache License 2.0
14 stars 36 forks source link

Make sure bbr no link tests actually test without links #48

Closed rkoster closed 5 years ago

rkoster commented 5 years ago

This PR is a follow up on #46, apparently links where not fully disabled on my test. So to instances of the link helper function where not covered.

Got the tests to run in my environment and have implemented the fix TDD style (made sure the test failed first).

Apologies for the incomplete first PR.

cfdreddbot commented 5 years ago

:white_check_mark: Hey rkoster! The commit authors and yourself have already signed the CLA.

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/162792973

The labels on this github issue will be updated when the story is started.

rkoster commented 5 years ago

@suhlig Thanks for merging, any ETA on cutting a new release?

valeriap commented 5 years ago

@rkoster v34 has been published.

rkoster commented 5 years ago

Thanks!