cloudfoundry / pxc-release

BOSH release of Percona Xtradb Cluster
Apache License 2.0
30 stars 22 forks source link

Bump ginkgo v2 #38

Closed abg closed 1 year ago

abg commented 1 year ago

Feature or Bug Description

Bump from ginkgo/v1 to the latest ginkgo v2.9.0 and updates any existing ginkgo/v2 uses to v2.9.0

Motivation

Bumping dependencies. This should address some of the outstanding security flags for some of the outdated Go deps used by this project and consistently use the latest Ginkgo v2 testing framework across components in pxc-release.

ryanwittrup commented 1 year ago

overall this looks good to me for merging - not sure if we want any more eyes on it for a review?

the changes all look fairly straightforward, the bulk of the changes are new vendored dependencies and updating the import statements

using the "go run" syntax as advertised in the ginkgo docs where possible, updating from how we were previously vendoring it in via a tools.go file

all CLI flags are updated to kebab case from camel case

ready to merge if we don't need more reviews

abg commented 1 year ago

Merged. Thanks for looking it over @ryanwittrup