Adding Sealights Hook Support

cloudfoundry / python-buildpack

Cloud Foundry buildpack for the Python Language

http://docs.cloudfoundry.org/buildpacks/

Apache License 2.0

119 stars 277 forks source link

Adding Sealights Hook Support #809

Closed liornabat-sealights closed 1 year ago

liornabat-sealights commented 1 year ago

Thanks for contributing to the buildpack. To speed up the process of reviewing your pull request please provide us with:

A short explanation of the proposed change: This PR adds the support of Sealights agent
An explanation of the use cases your change solves
[x ] I have viewed signed and have submitted the Contributor License Agreement
[x ] I have made this pull request to the develop branch
[x] I have added an integration test

brayanhenao commented 1 year ago

@liornabat-sealights Could you create a new PR with the fixes that @robdimsdale commented above?

liornabat-sealights commented 1 year ago

Yes I can do that but this is not a small task and we are already two months trying to merge it and another delay will be a big problem for our clients.

On Thu, Aug 17, 2023 at 7:37 PM Brayan Henao @.***> wrote:

@liornabat-sealights https://github.com/liornabat-sealights Could you create a new PR with the fixes that @robdimsdale https://github.com/robdimsdale commented above?

— Reply to this email directly, view it on GitHub https://github.com/cloudfoundry/python-buildpack/pull/809#issuecomment-1682611026, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW4PJBOT34BSPBPOHLLKMOTXVZCD7ANCNFSM6AAAAAA3CLVRVE . You are receiving this because you were mentioned.Message ID: @.***>

robdimsdale commented 1 year ago

@liornabat-sealights we already merged your PR so the functionality is there. I appreciate this is taking a while, but at the same time we want to keep code quality high. That helps everyone - including your clients.

liornabat-sealights commented 1 year ago

No problem, I understand. Will do it soon and submit a new PR.

On Thu, Aug 17, 2023, 20:17 Rob Dimsdale-Zucker @.***> wrote:

@liornabat-sealights https://github.com/liornabat-sealights we already merged your other PR so the functionality is there. I appreciate this is taking a while, but at the same time we want to keep code quality high. That helps everyone - including your clients.

— Reply to this email directly, view it on GitHub https://github.com/cloudfoundry/python-buildpack/pull/809#issuecomment-1682672148, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW4PJBM2ETAZM2RFBO7PVJLXVZG2NANCNFSM6AAAAAA3CLVRVE . You are receiving this because you were mentioned.Message ID: @.***>

liornabat-sealights commented 1 year ago

@brayanhenao @robdimsdale , I have create a PR per your request. https://github.com/cloudfoundry/python-buildpack/pull/812