cloudfoundry / routing-release

This is the BOSH release for cloud foundry routers
Apache License 2.0
43 stars 106 forks source link

[PG4TAS-405] Add additional_bpm_mount_paths to route_registrar job spec #388

Closed amansingh066 closed 3 months ago

amansingh066 commented 9 months ago

What is this change about?

This change adds a new field in the route_registrar job's health-check object in its spec file: additional_bpm_mount_paths. Using this array of strings, the route_registrar job users can specify additional directories to be mounted in the bpm config yaml of the job. This is needed because sometimes the access to /var/vcap/job and /var/vcap/data/ directories of a specific job is not sufficient for a healthcheck script to run.

What type of change is this?

If you have selected multiple of the above, it may be wise to consider splitting this PR into multiple PRs to decrease the time for minor changes + bugs to be resolved.

Backwards Compatibility

The change is backwards compatible. No existing deployments configuration should break due to this change.

I don't think it should be considered experimental for some period. I think it should go in next major/minor release. This doesn't need to apply immediately to all routing-release deployments.

How should this be tested?

Are there any non-automated tests that should be performed against this change for validation? Please provide steps, and expected results for before + after the change.

Additional Context

Please provide any additional links or context (issues, other PRs, Slack discussions) to help understand this change.

PR Checklist

linux-foundation-easycla[bot] commented 9 months ago

CLA Not Signed