cloudfoundry / routing-release

This is the BOSH release for cloud foundry routers

Apache License 2.0

42 stars 106 forks source link

Add option to enable concurrent reads and writes for HTTP/1 #389

Closed mariash closed 7 months ago

mariash commented 7 months ago

What is this change about?

Bump negroni to latest to get support for ResponseController in Go 1.20+ to enable full-duplex mode for HTTP/1 requests. See more: https://pkg.go.dev/net/http#ResponseController.EnableFullDuplex

Waiting on the negroni release. Meanwhile bumped it to latest manually:

go get github.com/urfave/negroni/v3@master
go mod vendor

What type of change is this?

[ ] [Breaking Change]: the change removes a feature or introduces a behavior change to core functionality (request routing, request logging)
[X] [Minor Feature/Improvement]: the change introduces a new feature or improvement that doesn't alter core behavior
[ ] [Bug Fix]: the change addresses a defect

Backwards Compatibility

There should not be backwards compatibility issues since this is not an API change. This is an improvement for HTTP/1 requests.

How should this be tested?

There is an automated test provided in this PR as well as some manual validation that can be performed.

Additional Context

Please provide any additional links or context (issues, other PRs, Slack discussions) to help understand this change.

PR Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have made this pull request to the develop branch.
[X] I have run all the unit tests.
[X] I have given thought to the backward-compatibility requirements of this change, and listed any mitigations above.
[ ] (Optional) I have run Routing Acceptance Tests and Routing Smoke Tests.
[ ] (Optional) I have run CF Acceptance Tests.