search

cloudfoundry / ruby-buildpack

Cloud Foundry buildpack for Ruby, Sinatra and Rails
http://docs.cloudfoundry.org/buildpacks/
Apache License 2.0
65 stars 160 forks source link

Ruby buildpacks do not work well with bundler >= 2.2.x #301

Closed matobinder closed 3 years ago

matobinder commented 3 years ago

What version of Cloud Foundry and CF CLI are you using? (i.e. What is the output of running cf curl /v2/info && cf version?

    cf version 6.44.1+c3b20bfbe.2019-05-08
   "build": "2.7.33-build.38",
   "api_version": "2.139.0",
   "osbapi_version": "2.15",

What version of the buildpack you are using? ruby_buildpack-cached-cflinuxfs3-v1.8.39.zip

If you were attempting to accomplish a task, what was it you were attempting to do? cf push

What did you expect to happen? To give this warning (invalid warning)

What was the actual behavior? It gave this warning (which is false)

**WARNING** Removing `Gemfile.lock` because it was generated on Windows.

The bug is actually from this function in the repo https://github.com/cloudfoundry/ruby-buildpack/blob/master/src/ruby/versions/ruby.go#L200

With bundler 2.2.x the PLATFORMS section no longer just says ruby It looks like this

PLATFORMS
  x86_64-linux

So merely checking for ruby or java no longer suffices

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/178876125

The labels on this github issue will be updated when the story is started.

arjun024 commented 3 years ago

Fixed in v1.8.46