search

cloudfoundry / ruby-buildpack

Cloud Foundry buildpack for Ruby, Sinatra and Rails
http://docs.cloudfoundry.org/buildpacks/
Apache License 2.0
65 stars 160 forks source link

Migrate test suite to switchblade #977

Closed robdimsdale closed 3 months ago

robdimsdale commented 4 months ago
sophiewigmore commented 4 months ago

It's hard to comment because my GH UI keeps freezing. My main point of review is understanding the reasons we deleted some tests with no replacement. I understand some might not be good tests, or might be out of date. Some explanation of the more controversial removals might be useful

robdimsdale commented 4 months ago

It's hard to comment because my GH UI keeps freezing

😬

Some explanation of the more controversial removals might be useful

Sure. But I don't know what you consider controversial :)

I can go through and explain each test removal

sophiewigmore commented 4 months ago

@robdimsdale I can try to save you some time and make a list of the ones im wondering about

sophiewigmore commented 3 months ago

@robdimsdale I think we covered the main items I was concerned about, let's get this merged in