Helm chart support for ingressClass

cloudfoundry / service-fabrik-broker

Cloud Foundry service broker which provisions service instances as Docker containers and BOSH deployments.

Apache License 2.0

41 stars 50 forks source link

Helm chart support for ingressClass #1605

Open gberche-orange opened 2 years ago

gberche-orange commented 2 years ago

Describe the bug

As a service operator,

in order to deploy interoperator in a cluster with multiple ingress controllers,
I need to be able to specify an ingressClassName on the broker ingress

What's the usual contribution/test process for such small PRs ? Is there an existing automated test suite for the helm chart that SAP maintains in a private build that could be shared ? Is it instead manual testing from the helm sources ?

cf-gitbot commented 2 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/181831250

The labels on this github issue will be updated when the story is started.

anoopjb commented 2 years ago

Hi, @gberche-orange,

Thank you for the suggestions. We do have some internal test beds based on Gardener project. But unfortunately, it is not easy to share the setup. If you plan to contribute, I can do a sanity check on the changes.