Socks5Proxy and HostKey do not have dial timeout

cloudfoundry / socks5-proxy

This is a go library for starting a socks5 proxy server via SSH

https://cloudfoundry.org

Apache License 2.0

52 stars 21 forks source link

Closed jamesjoshuahill closed 6 years ago

jamesjoshuahill commented 6 years ago

Whilst investigating https://github.com/cloudfoundry/bosh-cli/issues/432 the BOSH CLI hung indefinitely because the Socks5Proxy and HostKey do not set a Timeout in their ssh.ClientConfig.

Would you accept a PR to timeout after, say, 30 seconds?

Josh and @mirahimage

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

The labels on this github issue will be updated when the story is started.

cwlbraa commented 6 years ago

yes