Set a 30s timeout in ssh client config

cloudfoundry / socks5-proxy

This is a go library for starting a socks5 proxy server via SSH

https://cloudfoundry.org

Apache License 2.0

52 stars 21 forks source link

Set a 30s timeout in ssh client config #11

Closed jamesjoshuahill closed 6 years ago

jamesjoshuahill commented 6 years ago

To avoid hanging indefinitely when establishing the TCP connection. For example, when the remote is unreachable.

30 seconds is the timeout used by the default HTTP client in cloudfoundry/bosh-utils, see https://github.com/cloudfoundry/bosh-utils/blob/b082aa9a81950fa8df1a969575319417b1e073f4/httpclient/default_http_clients.go#L18.

Resolves https://github.com/cloudfoundry/socks5-proxy/issues/10.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/157978134

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 6 years ago

Hey jamesjoshuahill!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.