As a user of socks5-proxy, I'd like to configure 'user' from the outside, such that I don't need an account called 'jumpbox' on my system where everyone needs the private key file

cloudfoundry / socks5-proxy

This is a go library for starting a socks5 proxy server via SSH

https://cloudfoundry.org

Apache License 2.0

52 stars 21 forks source link

As a user of socks5-proxy, I'd like to configure 'user' from the outside, such that I don't need an account called 'jumpbox' on my system where everyone needs the private key file #5

Closed voelzmo closed 6 years ago

voelzmo commented 6 years ago

Hey,

how would you feel if we changed https://github.com/cloudfoundry/socks5-proxy/blob/master/socks5_proxy.go#L68 to take in an optional username additionally to the key file?

The reason is: we already have a jumpbox in place, where everyone has a named user and access control is managed by an outside system. It would be cool to be able to use BOSH_ALL_PROXY in the CLI and just tunnel on-demand.

wdyt? /cc @cppforlife

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155126239

The labels on this github issue will be updated when the story is started.

cppforlife commented 6 years ago

evanfarrar commented 6 years ago

Hey @voelzmo !

We hardcoded this originally because it had a very specific intent (BBL) but if there's interest I am happy to prioritize a change to respect a username value (and already have prioritized it). This will just cover the changes necessary in socks5-proxy though; I'll close this issue when we have made the change so that you or @cppforlife could make the dependency bump in the BOSH CLI.