Introduce `username` for Socks5Proxy

voelzmo commented 6 years ago

Note: this changes two public methods, not sure what your policy is for users of this project.

Dialer gets a new parameter username
HostKeyGetter#Get takes in the username instead of NewHostKeyGetter. This is to make the flow around Dialer with a username less cumbersome.
Fakes are re-generated with recent counterfeiter, which moves the fakes to a different location depending on the faked package. If you'd like to stick to the generic fakes directory, I'm happy to switch to a different counterfeiter version

Let me know how you feel about this PR.

closes #5

cfdreddbot commented 6 years ago

Hey voelzmo!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155320626

The labels on this github issue will be updated when the story is started.

cloudfoundry / socks5-proxy

Introduce `username` for Socks5Proxy #6