search

cloudfoundry / socks5-proxy

This is a go library for starting a socks5 proxy server via SSH
https://cloudfoundry.org
Apache License 2.0
49 stars 21 forks source link

Allow proxy.Start() to receive username #8

Closed luan closed 6 years ago

luan commented 6 years ago

Not every environment will have a username named 'jumpbox', this makes it so that the consumer has to pass a username (or "" for the default of jumpbox), similar to the Dialer.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155601485

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 6 years ago

Hey luan!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

evanfarrar commented 6 years ago

Hey Luan! Thanks for the PR. I don't know if I understand the difference between this and https://github.com/cloudfoundry/socks5-proxy/pull/6 on the surface, but we'll take a look.