[FEATURE] the buildpack should allow multi-buildpack deps dirs to be served

cloudfoundry / staticfile-buildpack

Deploy static HTML/JS/CSS apps to Cloud Foundry

Apache License 2.0

201 stars 326 forks source link

[FEATURE] the buildpack should allow multi-buildpack deps dirs to be served #121

Closed jpluscplusm closed 6 years ago

jpluscplusm commented 7 years ago

There doesn't appear to be a multi-buildpack-contract-compliant way of specifying:

this buildpack should be the final buildpack in a cf v3-push -b foo -b bar -b staticfile push
the files served by nginx should be (or include some) from one of the dependency directories populated by the foo or bar buildpacks' supply scripts

I've tried a number of hacks (symlinks; absolute paths in the root: Staticfile directive; etc), but I can only currently achieve this by making a previous buildpack's supply script modify the app dir contents - which is explicitly prohibited in https://docs.cloudfoundry.org/buildpacks/understand-buildpacks.html#supply-script

In a multi-buildpack world, serving a directory built by a previous buildpack doesn't sound outrageous. I think this buildpack should support that use case.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/151787565

The labels on this github issue will be updated when the story is started.

sclevine commented 7 years ago

Hi @jpluscplusm,

What's your use case for this feature? What type of files are you trying to share between static-content apps?

You may be able to accomplish this now with the location_include Staticfile directive, but I'd like to understand your motivations before going into more detail about that option.

(We have plans to introduce an NGINX buildpack that requires a user-specified nginx.conf file. This may be a better feature for that buildpack.)

sclevine commented 6 years ago

Hi @jpluscplusm,

Still interested in this feature?

sclevine commented 6 years ago

Closing due to inactivity. We may implement something like this eventually, but we don't have plans to do so yet.

efriese commented 2 years ago

Could this feature request be opened again? We have a use case where this is causing an issue. We utilize the Signal Science WAF and the easiest way to incorporate the agent is using the supply buildpack provided by the vendor. We're seeing more staticfile buildpacks pop up in our organization and we can't use that buildpack with the staticfile buildpack.