Remove hard link between cf and autoscaler packages

cloudfoundry / stratos

Stratos: Web-based Management UI for Cloud Foundry and Kubernetes

Apache License 2.0

244 stars 131 forks source link

Remove hard link between cf and autoscaler packages #4416

Open richard-cox opened 4 years ago

richard-cox commented 4 years ago

Cf package depends on autoscaler in two places

ApplicationsModule (brings in app autoscaler tab via CfAutoscalerModule)
- this also creates a depency in CloudFoundryTestingModule
CardCfInfoComponent (shows AS version via fetchAutoscalerInfo)

Ideally it would be nice to remove this hard link and only show functionality if autoscaler package is present

mmavrudiev commented 4 years ago

Recently we have discovered that on stratos UI the Autoscaler version shows 3.0.0 but actually it should show 3.0.1 since we have updated that.

We are using bosh release for autoscaler.

Is that a known issue to which you are referring here or a different one?

richard-cox commented 4 years ago

@mmavrudiev Unfortunately this is a different one. The autoscaler version comes directly from the autoscaler service (if you inspect the network requests you should see this as something like pp/v1/autoscaler/info). If possible, could you check the build value in the response to that request? If it's correct there could you create a new Github issue here, otherwise you'll need to reach out to the Autoscaler team.

richard-cox commented 4 years ago

I tried to neaten this up to allow npm link'ing of cf autoscaler.

application.module.ts changed,

+import { CfAutoscalerModule } from '@stratosui/cf-autoscaler';

-import { CfAutoscalerModule } from '../../../../cf-autoscaler/src/cf-autoscaler.module';

CfAutoscalerModule exported in cf autoscalers public_api
This revealed a hidden circular dependency (Cf AS depends on CF shared module for a component and app service)