search

cloudfoundry / switchboard

Golang TCP Proxy
Apache License 2.0
33 stars 9 forks source link

Add compatibility for the opensuse stack #11

Closed dragonchaser closed 6 years ago

dragonchaser commented 6 years ago

This PR adds compatibility for the opensuse stack. The arp binary resides in /sbin instead of /usr/sbin there.

cfdreddbot commented 6 years ago

Hey dragonchaser!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155462490

The labels on this github issue will be updated when the story is started.

menicosia commented 6 years ago

Hi @dragonchaser,

Say, have you seen the deprecation notice in the v36.11.0 release notes? It's funny that you happen to come upon this just as we're starting to recommend that folks start to rely on the BOSH director to do the same.

Write back and tell me what you think!

-- Marco Nicosia Product Manager Pivotal Software, Inc.

dragonchaser commented 6 years ago

Hi @menicosia, the bug does not affect us that much (since we rely on kubernetes), we just saw it and attempted to fix it. So you can either merge it for now until this code part gets removed or drop the PR. (We can temporarily fix it using a symlink on our stemcell.)

Regards Christian Richter

menicosia commented 6 years ago

Wow, thank you for taking the time to submit a fix!

I'm glad that you're not directly affected by the bug. We are planning to rely on BOSH (or whatever is responsible for abstracting the IaaS) to take care of ARP-related problems. We're eager to scrap this section of the code, it's definitely in "deprecated" mode now.

So, for that reason, I'll close this PR un-merged, if only to avoid the appearance that we're still maintaining the code base.

Please feel free to keep citing issues, and providing PRs if you can! We're happy to hear from you.

-- Marco Nicosia Product Manager Pivotal Software, Inc.