Use of legacy library commons-httpclient:commons-httpclient:3.1

peterhaochen47 commented 8 months ago

This library is very old and needs to be replaced.

Some examples of usage in our code:

In ExternalOAuthAuthenticationFilter.java

import org.apache.commons.httpclient.util.URIUtil; ... final String origin = URIUtil.getName(String.valueOf(request.getRequestURL()));

And in TokenMvcMockTests.java in the invalidScopeErrorMessageIsNotShowingAllClientScopes and invalidScopeErrorMessageIsNotShowingAllUserScopes test methods, for the same import.

See further discussion here: https://github.com/cloudfoundry/uaa/pull/2689#discussion_r1466794219

### Tasks
- [x] Remove direct usage, see https://github.com/cloudfoundry/uaa/pull/2826
- [ ] Solve https://github.com/cloudfoundry/uaa/issues/2561

cf-gitbot commented 8 months ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186918404

The labels on this github issue will be updated when the story is started.

strehle commented 5 months ago

Will remove UAA usages, but the external dependency still requires it, see dep. tree

cf-gitbot commented 5 months ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/187425661

The labels on this github issue will be updated when the story is started.

cloudfoundry / uaa

Use of legacy library commons-httpclient:commons-httpclient:3.1 #2691