cloudfour / cloudfour-boxen

Boxen
MIT License
0 stars 0 forks source link

Add `strict` to our jshintrc #45

Open lyzadanger opened 9 years ago

lyzadanger commented 9 years ago

Per your email! Please update our jshintrc dotfile with the strict switch.

Do this on a branch and PR it so I can try the branch out locally before inflicting it on people!

Should be quick, I hope, for you!

lyzadanger commented 9 years ago

@lharding The more I'm looking at jshint docs the more I think we want no option for this in our .jshintrc. Neither strict nor globalstrict. If we use strict, jshint will bitch unless you declare use strict in every declared function. That's worse than before and the reason I gravitated to globalstrict so at least I only had to put use strict once per source file.

I'm beginning to think the jshint linter in atom might be leading me astray. It won't lint unless it sees use strict somewhere, in my previous experiences. This is dumb. It should lint assuming strict mode. So maybe I have some research of my own to do.

The maintainer of jshint also is the maintainer of the node hardware library I contribute to, johnny-five. That project's jshint looks like this. It's more opinionated than we need, but note absence of any reference to strict mode declaration.

lyzadanger commented 9 years ago

Point being: I think we should strip the reference to globalstrict, not change it to strict.