cloudfour / cloudfour-boxen

Boxen
MIT License
0 stars 0 forks source link

Node is old #52

Closed erikjung closed 9 years ago

erikjung commented 9 years ago

I assume that we're due to update https://github.com/boxen/puppet-nodejs from 4.0 to 5.0 (unless that's not a requirement for us to update our Node version from 0.10 to say... 4.0?)

Anyway, I've encountered a few instances of NPM packages depending on at least Node 0.12 due to ES6 stuff. It would be oh so nice to use the latest and greatest. I don't know what this entails exactly, so maybe @lyzadanger or @lharding can update this thread with a task list of some kind.

lyzadanger commented 9 years ago

@erikjung The plan is that we follow upstream on this. Upstream being github. When their manifest starts installing node 0.12, we'll do it. I have a hunch it may jump straight to 4.0 ultimately.

See: https://github.com/boxen/our-boxen/blob/master/manifests/site.pp

If you personally need node 0.12 for personal/exploratory stuff, I think you can add it to your own person module using the formulae as you see in that site.pp above.

lyzadanger commented 9 years ago

p.s. ...don't make it system-wide node version plz.

erikjung commented 9 years ago

@lyzadanger I'm noticing that our-boxen defines the Node versions differently than we do.

https://github.com/boxen/our-boxen/blob/master/manifests/site.pp#L66-L69

nodejs::version { '0.6': }
nodejs::version { '0.8': }
nodejs::version { '0.10': }

https://github.com/cloudfour/cloudfour-boxen/blob/master/manifests/site.pp#L66-L69

nodejs::version { 'v0.6': }
nodejs::version { 'v0.8': }
nodejs::version { 'v0.10': }

Does this matter at all? Is the v optional?

lyzadanger commented 9 years ago

@erikjung It's because we haven't merged upstream lately. See #50 — this is happening imminently.

erikjung commented 9 years ago

:+1:

erikjung commented 9 years ago

In my attempts to specify a newer version of Node in my erikjung.pp manifest, I have learned that:

Error: Duplicate declaration: 
Class[Nodejs::Global] is already declared in file /opt/boxen/repo/modules/people/manifests/erikjung.pp:25; 
cannot redeclare at /opt/boxen/repo/modules/cloudfour/manifests/init.pp:57

This makes me think that my changes to erikjung.pp will always be overridden by cloudfour/manifests/init.pp.