Closed tylersticka closed 8 years ago
Sweet! 👍
Clever solution!
Regarding my comment about the partial, we can also do that later if you want to make an issue for it.
LGTM 👍
Regarding my comment about the partial, we can also do that later if you want to make an issue for it.
I agree with this feedback and started implementing it, but ran into an immediate snag or two. I'll definitely make an issue.
This PR adds a new
page-item
partial, which leverages a newFrameThumb
pattern. This displays the pages with aniframe
-based thumbnail, similar to CodePen and one of our old bespoke pattern libraries.The biggest change from our previous implementations of this pattern are that the thumbnail itself is flexible, there's still plenty of room available for text-based descriptions, and loading of actual
iframe
elements is deferred till the rest of the page has loaded.Screenshots
Narrow
Wide
@mrgerardorodriguez @erikjung @saralohr @nicolemors @aileenjeffries
Closes #8, See #19