search

cloudfour / fabricator

A tool for building website UI toolkits
http://fbrctr.github.io/
1 stars 0 forks source link

Initial tweaks to build, directories, etc. #1

Closed erikjung closed 9 years ago

lyzadanger commented 9 years ago

Hiya, @erikjung !

I think a plan here might be to go ahead and merge this into the dev branch and then I can address the things I noted. I have an idea of how to make the Handlebars helpers less crazy-making, e.g., which I see is something @erikjung has already thought of also.

I'm not quite tuned into fabricator's CSS structure for its toolkit area (I presume this to be the CSS that defines the appearance of the pattern-library UI itself) to be able to evaluate your CSS changes. Are those new files exclusively suitcss support/utilities or are you making some further decisions beyond that? Is this something we might want @tylersticka to take a peek at?

erikjung commented 9 years ago

@lyzadanger I took the initiative to flesh out the CSS area mainly to verify that the cssnext importing did in fact work as expected, and also to stub out how SUIT modules could be used and extended if needed.

I presume this to be the CSS that defines the appearance of the pattern-library UI itself

To clarify, toolkit.css is the pattern library content (stuff we define), and fabricator.scss is the presentational structure (sidebar UI mostly). The Fabricator stuff is still written in Sass (which actually might be a nice differentiator).

lyzadanger commented 9 years ago

For purposes of speed, I'm going to go ahead and merge this unless you demur @erikjung . I can then work on another branch off dev to do some more stuff.