Feature: keyboard shortcuts for toggles

cloudfour / fabricator

A tool for building website UI toolkits

http://fbrctr.github.io/

1 stars 0 forks source link

Closed erikjung closed 9 years ago

erikjung commented 9 years ago

This adds the ability to use keyboard commands for toggling the state/visibility of notes, labels and code examples.

The chosen commands:

const LABELS_SHORTCUT = 'ctrl a';
const CODE_SHORTCUT = 'ctrl s';
const NOTES_SHORTCUT = 'ctrl d';

Alternative suggestions welcome. Here are the available keys.

I used ctrl in order to not trigger anything when <input>s within materials are interacted with.

cc @tylersticka

lyzadanger commented 9 years ago

Is this PR still valid in light of @tylersticka 's considerable changes to structure? Sorry it's been languishing. Ready to think about it now :)

erikjung commented 9 years ago

Yes, it should be.

lyzadanger commented 9 years ago

My only hesitation is that I think the label show-hide feature is kind of silly. Thoughts?

Otherwise, totally rock on and :star: for that ES6 module syntax.

tylersticka commented 9 years ago

I say "keep it" because it's already in there and it feels weird to remove one Fabricator feature while keeping the others intact.

lyzadanger commented 9 years ago

@tylersticka Yeah, can't hurt.