search

cloudfour / fabricator

A tool for building website UI toolkits
http://fbrctr.github.io/
1 stars 0 forks source link

Hooking up external links to actual data #23

Closed tylersticka closed 9 years ago

tylersticka commented 9 years ago

This takes the previously non-functional "external link" HTML/CSS and wires it up to support actual data.

lyzadanger commented 9 years ago

Hi! This looks good, but does bring up a tangential equation about how we want to maintain documentation for our alterations? Perhaps amend the repo-wide README? I'm open to suggestions.

tylersticka commented 9 years ago

I think it makes sense to maintain our own README.

tylersticka commented 9 years ago

@lyzadanger Is there any action required now for this PR specifically before it can be merged?

lyzadanger commented 9 years ago

@tylersticka You choice on whether you want to introduce a new README as part of this PR or after!

tylersticka commented 9 years ago

After! I've got at least two other tweaks I'd like to make and then that seems like a good time to write one.

I'll make an issue for it, though!